clarify destination rule docs#2428
Merged
istio-testing merged 3 commits intoistio:masterfrom Jul 29, 2022
Merged
Conversation
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
ramaraochavali
requested review from
ericvn,
howardjohn,
linsun,
louiscryan and
nrjpoddar
as code owners
istio-testing
added
the
size/XS
ramaraochavali
added
release-notes-none
ericvn
reviewed
Jul 25, 2022
| // Settings applicable to HTTP1.1/HTTP2/GRPC connections. | ||
| message HTTPSettings { | ||
| // Maximum number of pending HTTP requests to a destination. Default 2^32-1. | ||
| // Please note that this is applicable to both HTTP1.1/ and HTTP2. |
There was a problem hiding this comment.
HTTP/1.1 instead of HTTP1.1/ or leave the / out entirely as it's not in HTTP2.
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
istio-testing
added
the
size/XS
ericvn
approved these changes
Jul 25, 2022
howardjohn
reviewed
Jul 25, 2022
|
|
||
| // Maximum number of requests to a backend. Default 2^32-1. | ||
| // Please note that this is applicable to both HTTP/1.1 and HTTP2. | ||
| int32 http2_max_requests = 2; |
Member
There was a problem hiding this comment.
so is it identical to http1_max_pending_requests then
Contributor
Author
There was a problem hiding this comment.
It is not exactly same. http2_max_requests is how many concurrent active requests can be there. max_pending_requests is how many requests can be in pending queue waiting for connection.
Specifically for pending requests,
"For HTTP/2 connections, if max concurrent streams and max requests per connection are not configured, all requests will be multiplexed over the same connection so this circuit breaker will only be hit when no connection is already established"
So there is subtle difference on how http2 protocol options are setup.
Member
There was a problem hiding this comment.
Should we clarify this difference in our api comments?
Contributor
Author
There was a problem hiding this comment.
yeah. good point. Let me update it.
Contributor
Author
There was a problem hiding this comment.
updated the docs. Defaults are also incorrect. Fixed them
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
istio-testing
added
size/S
Contributor
Author
|
@howardjohn can you PTAL when you get chance? |
howardjohn
approved these changes
Jul 29, 2022
frittentheke
added a commit
to frittentheke/istio
that referenced
this pull request
Sep 19, 2025
…pplied to certain HTTP version The circuit-breaker connection pool settings `MaxRequests`and `MaxPendingRequests` apply to HTTP/1.1 as well as HTTP/2 since [1] and [2]. This was actually changed in the Istio docs via [3], but these source code comments were left, potentially causing confusion. [1] envoyproxy/envoy#9215 [2] envoyproxy/envoy#9668 [3] istio/api#2428 Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
frittentheke
added a commit
to frittentheke/istio
that referenced
this pull request
Sep 19, 2025
…pplying to particular HTTP version The circuit-breaker connection pool settings `MaxRequests`and `MaxPendingRequests` apply to HTTP/1.1 as well as HTTP/2 since [1] and [2]. This was actually changed in the Istio docs via [3], but these source code comments were left, potentially causing confusion. [1] envoyproxy/envoy#9215 [2] envoyproxy/envoy#9668 [3] istio/api#2428 Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
istio-testing
pushed a commit
to istio/istio
that referenced
this pull request
Sep 20, 2025
…pplying to particular HTTP version (#57705) The circuit-breaker connection pool settings `MaxRequests`and `MaxPendingRequests` apply to HTTP/1.1 as well as HTTP/2 since [1] and [2]. This was actually changed in the Istio docs via [3], but these source code comments were left, potentially causing confusion. [1] envoyproxy/envoy#9215 [2] envoyproxy/envoy#9668 [3] istio/api#2428 Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify Destination Rule docs that Max Pending Requests/ Max Requests apply to both Http1 and Http2
See istio/istio#31548 and envoyproxy/envoy#9668 (See version history and doc updates)